Skip to content

Remove SDK workaround #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2020
Merged

Remove SDK workaround #429

merged 2 commits into from
Jun 24, 2020

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented May 31, 2020 •
edited
Loading

Remove HACK for bug which the 3.1.3xx SDK fixes.

@martincostello
Update .NET Core SDK
d585900 
Update to the .NET Core 3.1.300 SDK.
Remove HACK for bug which it fixes.
@martincostello martincostello added this to the 3.1.2 milestone May 31, 2020
@martincostello
Copy link
Member Author

Appears to be working as expected:

image

@martincostello martincostello marked this pull request as ready for review May 31, 2020 17:51
kevinchalet
kevinchalet approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@kevinchalet kevinchalet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it fixes the bugs we had to work around when using the previous SDK version, then :shipit:

@martincostello martincostello changed the title Update .NET Core SDK Remove SDK workaround Jun 24, 2020
kevinchalet
kevinchalet approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@martincostello martincostello merged commit 67ba6f7 into aspnet-contrib:dev Jun 24, 2020
@martincostello martincostello deleted the Update-SDK-Remove-HACK branch June 24, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinchalet kevinchalet kevinchalet approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@martincostello @kevinchalet