Skip to content

Implement installation using trust #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 27, 2019
Merged

Implement installation using trust #116

merged 7 commits into from
Aug 27, 2019

Conversation

jamesmunns
Copy link

@jamesmunns jamesmunns commented Aug 27, 2019

Closes #115

@jamesmunns
Copy link
Author

Regarding the removal of cargo-install-update: It seemed to only serve to update mdbook (see context here), and trust will install the newest version always anyway.

@jamesmunns
Copy link
Author

This reduces CI time significantly.

Platform Old Time New Time
Total 73min 41 sec 28min 24 sec
Windows 32m 50s 14m 24s
Mac 19m 35s 7m 42s
Linux 21m 16s 6m 18s

@@ -1,30 +1,26 @@
language: rust

env:
Copy link
Author

@jamesmunns jamesmunns Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This env was replaced if one is defined in the matrix. This meant that previously this flag was only set on Windows builds.


script:
- if ![[ -n "$BUILD_BOOK" ]]; then cargo check --all --benches --bins --examples --tests && cargo test --all; fi
- if [[ -n "$BUILD_BOOK" ]]; then cargo test --all --benches --bins --examples --tests; fi
- if ! [[ -n "$BUILD_BOOK" ]]; then cargo check --all --benches --bins --examples --tests && cargo test --all; fi
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

![[ is treated differently than ! [[. The latter is what we wanted.

# https://github.com/rust-embedded/book/blob/master/ci/install.sh

main() {
# Note - this will only accept releases tagged with v0.3.x
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have semver expectations for the book, but this matches the previous behavior of --version "^0.3"

@skade
Copy link
Collaborator

skade commented Aug 27, 2019

Looks good to me!

@skade skade merged commit d89b384 into master Aug 27, 2019
@ghost ghost deleted the install-mdbook-bin branch August 27, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid building mdbook in CI
2 participants