Simplify extension traits using a macro #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Sep 26, 2019
| /// The type of items yielded by this stream. | ||
| type Item; | ||
|
|
||
| #[doc = r#" |
There was a problem hiding this comment.
We have to write docs in Stream in this style because the macro will otherwise exceed the recursion limit and dramatically slow compilation down. That is because each line starting with /// is a token itself, but with #[doc = "..."] we can put the whole docs for a function into a single token tree, meaning the macro makes progress faster - instead of consuming docs line by line it consumes them in a single bite.
ghost
marked this pull request as ready for review
yoshuawuyts
approved these changes
Sep 27, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 27, 2019
241: Simplify extension traits using a macro r=yoshuawuyts a=stjepang This PR would fix #235 Async methods in our extension traits are now written in the simpler `-> impl Future<Output = T> [ConcreteFuture<Self>]` style. At the same time, doc tests are used even when the `docs` feature is not enabled. Co-authored-by: Stjepan Glavina <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would fix #235
Async methods in our extension traits are now written in the simpler
-> impl Future<Output = T> [ConcreteFuture<Self>]style. At the same time, doc tests are used even when thedocsfeature is not enabled.