Skip to content

Add GitHub Actions to the merge requirement of bors #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Oct 6, 2019

@yoshuawuyts
Copy link
Contributor

bors r+

@taiki-e
Copy link
Contributor Author

taiki-e commented Oct 6, 2019

Hmm..., bors does not seem to be able to get past the “waiting in the queue” stage...

bors ping

@bors
Copy link
Contributor

bors bot commented Oct 6, 2019

pong

@taiki-e
Copy link
Contributor Author

taiki-e commented Oct 6, 2019

bors r-

In any case, I think bors needs to be re-executed.

@bors
Copy link
Contributor

bors bot commented Oct 6, 2019

🔒 Permission denied

Existing reviewers: click here to make taiki-e a reviewer

@yoshuawuyts
Copy link
Contributor

Okay, let's try again!

bors r+

@yoshuawuyts
Copy link
Contributor

@taiki-e could you perhaps try removing Travis from the bors.toml requirements? I'm wondering what's making bors hang right now..

@yoshuawuyts
Copy link
Contributor

bors r+

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Oct 7, 2019

hmm, seems like bors is failing with "resource not accessible by integration". Maybe we need to re-authenticate bors?

@taiki-e
Copy link
Contributor Author

taiki-e commented Oct 7, 2019

Maybe we need to re-authenticate bors?

Probably, yes. I have confirmed changes included in this PR worked in the fork (taiki-e#1), so I think the changes themselves are not wrong.

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 8, 2019
@yoshuawuyts yoshuawuyts merged commit d1fe965 into async-rs:master Oct 10, 2019
@taiki-e taiki-e deleted the bors branch October 11, 2019 04:55
@yoshuawuyts yoshuawuyts added this to the 0.99.10 milestone Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants