Use once_cell instead of lazy_static #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`once_cell` provides a neat way of initializing lazy singletons without macro. This PR use `sync::Lazy` to streamline same pattern proposed in related rust RFC. Resolve async-rs#406
ghost
requested a review
from 
matklad
approved these changes
Oct 30, 2019
| static ref POOL: Pool = { | ||
| let num_threads = num_cpus::get().max(1); | ||
| let mut stealers = Vec::new(); | ||
| static POOL: Lazy<Pool> = Lazy::new(|| { |
There was a problem hiding this comment.
As this doesn't really make heavy use of Deref for Lazy, a more minimal and direct approach would be to use OnceCell.
static POOL: OnceCell<Pool> = OnceCell::new();
POOL.get_or_init(|| ...)But, as we are using Lazy elsewhere, I guess it's better to use it here as well, just for consistency
There was a problem hiding this comment.
Yeah, I make use of Lazy mostly to streamline with on-going rust RFC. I think this will be easier for later maintenance.
There was a problem hiding this comment.
The RFC proposes both OnceCell and Lazy, as OnceCell is strictly more powerful.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once_cellprovides a neat way of initializing lazy singletons withoutmacro. This PR use
sync::Lazyto streamline same pattern proposed inrelated rust RFC.
Resolve #406