Skip to content

Fix wasm, add wasm ci check, move files around to distinguish native and wasm code. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 1, 2020
Merged

Fix wasm, add wasm ci check, move files around to distinguish native and wasm code. #53

merged 8 commits into from
Feb 1, 2020

Conversation

expenses
Copy link
Contributor

Sorry, I missed this!

@expenses expenses changed the title Fix wasm, add gitlab workflow Fix wasm, add gitlab workflow for wasm Jan 27, 2020
@expenses expenses requested a review from yoshuawuyts January 27, 2020 11:54
@yoshuawuyts yoshuawuyts changed the title Fix wasm, add gitlab workflow for wasm Fix wasm, add githubworkflow for wasm Jan 27, 2020
@yoshuawuyts yoshuawuyts changed the title Fix wasm, add githubworkflow for wasm Fix wasm, add github workflow for wasm Jan 27, 2020
yoshuawuyts
yoshuawuyts approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thanks!

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Jan 27, 2020 •
edited
Loading

@expenses oh it seems WASM is failing on CI.

@expenses

This comment has been minimized.

Sign in to view
@expenses expenses changed the title Fix wasm, add github workflow for wasm Move files around to distinguish native and wasm code. Jan 27, 2020
@expenses expenses requested a review from yoshuawuyts January 27, 2020 14:22
@expenses expenses changed the title Move files around to distinguish native and wasm code. Fix wasm, add wasm ci check, move files around to distinguish native and wasm code. Jan 27, 2020
@expenses
Copy link
Contributor Author

@yoshuawuyts What do you think?

@yoshuawuyts yoshuawuyts merged commit afca27a into async-rs:master Feb 1, 2020
@yoshuawuyts yoshuawuyts mentioned this pull request Feb 1, 2020
Merged
oblique added a commit to oblique/rust-libp2p that referenced this pull request Jun 6, 2024
@oblique
fix(ping): Fixes panic in WASM caused by retrying on dail errors
85fdf92 
This PR workarounds async-rs/futures-timer#53 issue.

Fixes libp2p#5442
@oblique oblique mentioned this pull request Jun 6, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expenses @yoshuawuyts