Add missing symbolic operator characters. Remove non-keywords. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbolic operators can contain `&` and `=`, so add these to relevant regexes. Fix typo on "Capitol". Comparison, logical and arithmetic "keywords" are actually just methods in scala, so remove these. They also caused problems by matching against parts of other methods, like `===`. Add new match for assignment with `=`, making sure this doesn't match symbolic operators containing = character. Make sure that operators like `<-`, `=>` don't match against symbolic operators containing them as a substring.
|
@trepidacious could you update this pull-request? |
|
No problem, I think that does it - I've just brought across the changes from |
|
Thanks! Hopefully somebody will review it soon and merge. |
|
I'm not really sure either. I transferred the package to /atom-community/ because I wasn't really active in maintaining it anymore and so I guess anyone who is an owner there can merge in things and publish new versions. It's not clear what the process is to become a new owner. |
|
published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolic operators can contain
&and=, so add these to relevantregexes.
Fix typo on "Capitol".
Comparison, logical and arithmetic "keywords" are actually just methods
in scala, so remove these. They also caused problems by matching
against parts of other methods, like
===.Add new match for assignment with
=, making sure this doesn't matchsymbolic operators containing = character.
Make sure that operators like
<-,=>don't match against symbolicoperators containing them as a substring.