Skip to content

#30 Make installable and better error handling #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

Polleps
Copy link
Member

@Polleps Polleps commented Oct 27, 2022

PR Checklist:

import { useEffect, useState } from 'react';

/** Watches a media query and returns a statefull result. */
export function useMediaQuery(query: string): boolean {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this replace useWindowSize?

@joepio joepio marked this pull request as ready for review October 27, 2022 14:01
@joepio joepio merged commit 367c4b3 into main Oct 27, 2022
@joepio
Copy link
Member

joepio commented Oct 27, 2022

Failing tests are probably due to cookie auth issue. LGTM!

@joepio joepio deleted the #30-service-worker branch October 27, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installable as PWA - service worker & manifest
2 participants