Support auto_impl on borrowed references #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Oct 7, 2017
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "auto_impl" | |||
| version = "0.1.1" | |||
| version = "0.1.2" | |||
There was a problem hiding this comment.
This should be 0.2.0 as this pr is a functional change.
http://semver.org/#spec-item-6
- Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior.
- Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backwards compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.
There was a problem hiding this comment.
I think it's pretty common in the Rust ecosystem to use the patch version effectively as the minor is post 1.0 when the crate is pre 1.0, since we're only utilising two versions and aren't technically bound by semver anyways in 0.x.
If there's code that was accepted in 0.1.1 that isn't in 0.1.2 then I've messed up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
I've added a poor-man's parser for the
#[auto_impl]attribute so we can parse&and&mutcorrectly. We could probably do a better job of sharing code for smart pointers and reference types and dealing with malformed input, but this should be good enough.