Purge expired domains that fail the allow_domain check #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gohai
changed the title
gohai
force-pushed
the
renew-allow_domain-delete-expired
branch
from
8eac4b6 to
96fb3d1
Compare
The existing code would delete certificates from storage when issuing a new one failed and the old one has already expired. But since the check for allow_domain returns early, we'd never get rid of those for which allow_domain returns false - meaning the renewal checker would continue to check them going forward. This is based upon c263c52 because both are touching the same chunk.
gohai
force-pushed
the
renew-allow_domain-delete-expired
branch
from
96fb3d1 to
7aa9931
Compare
GUI
added a commit
that referenced
this pull request
Jul 20, 2020
|
Thank you! I've added some tests for this in 15afeb5, but otherwise, this looks good. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code would delete certificates from storage when issuing a new one failed and the old one has already expired. But since the check for allow_domain returns early, we'd never get rid of those for which allow_domain returns false - meaning the renewal checker would continue to check them going forward.