Skip to content

Add retry exception handler #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2022
Merged

Add retry exception handler #54

merged 2 commits into from
Oct 30, 2022

Conversation

SentryMan
Copy link
Contributor

@SentryMan SentryMan commented Oct 26, 2022 •
edited
Loading

  • Add a new default method to the RetryHandler Interface
  • use a do while block so exceptions can be retried
  • HttpException returns null for the body retrieving methods instead of throwing a NullPointerException.

Takes care of #53

@rbygrave rbygrave added this to the 1.20 milestone Oct 30, 2022
@rbygrave rbygrave linked an issue Oct 30, 2022 that may be closed by this pull request
Allow retries based on exception #53
Closed
@rbygrave rbygrave merged commit e99752b into avaje:master Oct 30, 2022
@SentryMan SentryMan deleted the exception-handling branch October 30, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SentryMan SentryMan

Labels
None yet
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.

Allow retries based on exception
2 participants
@SentryMan @rbygrave