-
Notifications
You must be signed in to change notification settings - Fork 14
Use @Singleton again #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @Singleton again #118
Conversation
Yeah, I don't think this is the best approach. We ideally have 4 cases to support.
As an alternative approach, it can detect avaje-inject and then failing that detect Jakarta or javax. |
I can easily add the avaje detection and use @component for cases 1 and 2. But for scenarios 3 and 4, I think defaulting to jakarta unless specified is the way to go. Consider the scenario where javax/jakarta just happens to be on the classpath because of a transitive dependency. How should the processor proceed? A flag makes it simple. |
@rbygrave how about this? Will use avaje if it's there. Otherwise will use either jakarta/javax on the classpath. If both are on the classpath, will default to jakarta, unless overridden by the flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, excellent.
Uh oh!
There was an error while loading. Please reload this page.