Skip to content

Use Prisms instead of using annotations directly #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Feb 10, 2023

Unfortunately, I still had to use the shade plugin to get it to work on a modular project.

  • use prisms instead of annotation
  • use antrun plugin to remove shaded deps from module-info
  • use moditect plugin to add modules-info into shaded jars
  • adds support for jakarta Email/Size/etc annotations
  • now reads all tag annotations from an element

Relies on avaje/avaje-prisms#7

@SentryMan
Copy link
Collaborator Author

I think I'm good with this

@rbygrave rbygrave merged commit ea616ba into avaje:master Feb 12, 2023
@SentryMan SentryMan deleted the prism branch February 12, 2023 00:04
@rbygrave rbygrave added this to the 1.26 milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants