Skip to content

OpenAPI documents support enumeration types #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2023
Merged

OpenAPI documents support enumeration types #177

merged 3 commits into from
Mar 10, 2023

Conversation

kevin70
Copy link
Contributor

@kevin70 kevin70 commented Mar 9, 2023

微信截图_20230309104611

I tried to add support for enumeration types in the OpenAPI document, but the current JSON cannot handle it correctly. Whether to consider introducing swagger core to support document processing? I feel this is necessary.

@SentryMan
Copy link
Collaborator

Whether to consider introducing swagger core to support document processing? I feel this is necessary.

remember we tried that before and it also didn't create the json correctly

@SentryMan
Copy link
Collaborator

SentryMan commented Mar 9, 2023

In line 84 of the OpenApiSerializer, replace the existing line with this.

sb.append(field.getName().replace("_enum", "enum"));

@rbygrave
Copy link
Contributor

rbygrave commented Mar 9, 2023

Is this PR completed now? It looks finished and ready to me.

@kevin70
Copy link
Contributor Author

kevin70 commented Mar 9, 2023

Yes, it's finished. Thanks.

@SentryMan
Copy link
Collaborator

LGTM

@rbygrave rbygrave added this to the 1.29 milestone Mar 10, 2023
@rbygrave rbygrave added the bug Something isn't working label Mar 10, 2023
@rbygrave rbygrave merged commit 271d1d0 into avaje:master Mar 10, 2023
@rbygrave rbygrave modified the milestones: 1.29, 1.30 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants