[http-client] Add SingleBodyAdapter for client API with only a single body type #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body type This provides a way to minimise the dependencies of an HttpClient that only has a single body type to support.
|
seems kinda specific but ok |
SentryMan
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a way to minimise the dependencies of an HttpClient that only has a single body type to support.
That is, make it easier to use sayjust avaje-json-core or avaje-json-node as a dependency to handle the response body &/or request body where the http endpoint only has the single body type to support [and arguably avaje-jsonb or Jackson is a bit "overkill"].
An alternative is this is to just to use raw body content like String or byte[], and handle it all without a BodyAdapter but this provides a more explicit API for that use case..