Skip to content

added fix and test for #179 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2021
Merged

added fix and test for #179 #183

merged 2 commits into from
Dec 23, 2021

Conversation

doppelrittberger
Copy link

@doppelrittberger doppelrittberger commented Dec 23, 2021 •
edited by rbygrave
Loading

Hi,

here is the PR for #179.

Thanks

TLDR: Support injection of empty List / Set of dependencies. Don't fail if the list/set of dependencies is empty.

@rbygrave rbygrave changed the title added fix and test for https://github.com/avaje/avaje-inject/issues/179 added fix and test for #179 Dec 23, 2021
@rbygrave rbygrave added the bug Something isn't working label Dec 23, 2021
@rbygrave rbygrave added this to the 6.20 milestone Dec 23, 2021
@rbygrave rbygrave linked an issue Dec 23, 2021 that may be closed by this pull request
List of implementing interfaces with generics - "No dependency provided" when injecting List or Set #179
Closed
@rbygrave rbygrave merged commit fc5b928 into avaje:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@doppelrittberger doppelrittberger

Labels
bug Something isn't working
Projects
None yet
Milestone
6.20
Development

Successfully merging this pull request may close these issues.

List of implementing interfaces with generics - "No dependency provided" when injecting List or Set
2 participants
@doppelrittberger @rbygrave