Skip to content

Injecting Generics refactor and fix #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 8, 2022
Merged

Injecting Generics refactor and fix #226

merged 15 commits into from
Jun 8, 2022

Conversation

rbygrave
Copy link
Contributor

@rbygrave rbygrave commented Jun 3, 2022

No description provided.

rbygrave added 2 commits June 3, 2022 16:49
@rbygrave
#224 - Injecting Generics with a Context generates bad code
3538944 
- Fixes this bug
- Changes Builder to use Type rather than Class with fairly big simplification of how generic types are handled
@rbygrave
#225 - Add BeanScope.list(Type) to support generic types
4924d0a
@rbygrave rbygrave added this to the 8.6 milestone Jun 3, 2022
@rbygrave rbygrave self-assigned this Jun 3, 2022
This was linked to issues Jun 3, 2022
Injecting Generics with a Context generates bad code. #224
Closed
Add BeanScope.list(Type) to support generic types #225
Closed
rbygrave added 9 commits June 3, 2022 17:05
@rbygrave
#225 - Refactor tidy MethodReader only
27b5ecc
@rbygrave
#225 - GenericType removes generic parameter types as well
ddd96c0
@rbygrave
#225 - Fix GenericType.getTypeName() for generic interface type with …
f2a5db8 
…no parameters
@rbygrave
#225 - Support generic types with factory methods
8672cd0 
See MyAutoNameFactory$DI
@rbygrave
#225 - Support generic types with factory methods
5f69678 
See MyAutoNameFactory$DI
@rbygrave
#225 - Add .type() to extract underlying Type from GenericType in gen…
8ff3c6a 
…erated code
@rbygrave
#225 - Simplify to always use GenericType.parse() to treat wildcard s…
a61b115 
…ame as rawtype
@rbygrave
#225 - Imports for the module should no longer include the type when …
109b8d8 
…it's a generic type
@rbygrave
#228 - Support generic super types e.g. CRUDService<T, KeyType> exten…
1c7bc0f 
…ds ReadService<T, KeyType>, ...
@rbygrave rbygrave linked an issue Jun 7, 2022 that may be closed by this pull request
Support generic super types e.g. CRUDService<T, KeyType> extends ReadService<T, KeyType>, ... #228
Closed
@rbygrave rbygrave linked an issue Jun 7, 2022 that may be closed by this pull request
Custom scope with @InjectModule can mess up the "default module @InjectModule" #229
Closed
@rbygrave rbygrave merged commit 5839695 into master Jun 8, 2022
@rbygrave rbygrave linked an issue Jun 8, 2022 that may be closed by this pull request
Gradle : Full recompilation is required because io.avaje.inject.generator.Processor is not incremental #227
Closed
@SentryMan SentryMan deleted the feature/224-generics branch August 30, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
8.6
1 participant
@rbygrave