Skip to content

Fixes Aspects not working for Certain Types #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2023
Merged

Fixes Aspects not working for Certain Types #251

merged 4 commits into from
Jan 5, 2023

Conversation

SentryMan
Copy link
Collaborator

  • updates param imports (added because Optional was not being added to imports)
  • aspect writing methods are separate

fixes #250

rbygrave added a commit that referenced this pull request Jan 5, 2023
@rbygrave
#251 - Adjustments for fixing Aspects on methods with generic parameters
23fb0bf
@rbygrave rbygrave merged commit 0e44d68 into avaje:master Jan 5, 2023
@rbygrave rbygrave added this to the 8.11 milestone Jan 5, 2023
@rbygrave rbygrave added the bug Something isn't working label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SentryMan SentryMan

Labels
bug Something isn't working
Projects
None yet
Milestone
8.11
Development

Successfully merging this pull request may close these issues.

Aspects don't work for collection type parameters
2 participants
@SentryMan @rbygrave