Skip to content

Fix Field Assisted Inject #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 14, 2024
Merged

Fix Field Assisted Inject #492

merged 11 commits into from
Feb 14, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jan 29, 2024 •
edited
Loading

Fix cases where field assists generate incorrectly.

  • now field assist will filter assisted elements by FIELD kind
  • adds back validation logic for mismatched number of parameters
  • support functional interfaces and abstract classes with non-abstract methods

@SentryMan SentryMan added the bug Something isn't working label Jan 29, 2024
@SentryMan SentryMan self-assigned this Jan 29, 2024
@SentryMan SentryMan added this to the 9.11 milestone Jan 29, 2024
@SentryMan SentryMan requested a review from rbygrave January 29, 2024 05:17
@SentryMan SentryMan enabled auto-merge January 29, 2024 05:18
@rbygrave rbygrave disabled auto-merge February 14, 2024 09:40
@rbygrave rbygrave merged commit 22165f7 into avaje:master Feb 14, 2024
@SentryMan SentryMan deleted the assisted-field branch February 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

Assignees

@SentryMan SentryMan

Labels
bug Something isn't working
Projects
None yet
Milestone
9.11
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave