Skip to content

Add Super Types to Auto Provides #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ List<String> provides() {
return typeReader.provides();
}

String autoProvides() {
List<String> autoProvides() {
return typeReader.autoProvides();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ final class MetaData {
/**
* Type deemed to be candidate for providing to another external module.
*/
private String autoProvides;
private List<String> autoProvides;

private boolean generateProxy;
private boolean usesExternalDependency;
Expand Down Expand Up @@ -138,7 +138,7 @@ List<Dependency> dependsOn() {
return dependsOn;
}

String autoProvides() {
List<String> autoProvides() {
return autoProvides;
}

Expand Down Expand Up @@ -219,7 +219,7 @@ void buildMethod(Append append) {
appendProvides(append, "dependsOn", dependsOn.stream().map(Dependency::dependsOn).collect(Collectors.toList()));
}
if (hasAutoProvides) {
append.append(",").eol().append(" autoProvides = \"").append(autoProvides).append("\"");
appendProvides(append, "autoProvides", autoProvides);
}
append.append(")").append(NEWLINE);
append.append(" private void build_").append(buildName()).append("() {").append(NEWLINE);
Expand Down Expand Up @@ -269,7 +269,7 @@ void setMethod(String method) {
this.method = method;
}

void setAutoProvides(String autoProvides) {
void setAutoProvides(List<String> autoProvides) {
this.autoProvides = autoProvides;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ MetaData createMeta() {
}
metaData.setDependsOn(dependsOn);
metaData.setProvides(typeReader == null ? Collections.emptyList() : typeReader.provides());
metaData.setAutoProvides(typeReader == null ? null : typeReader.autoProvides());
metaData.setAutoProvides(typeReader == null ? List.of() : typeReader.autoProvides());
metaData.setProvidesAspect(typeReader == null ? "" : typeReader.providesAspect());
return metaData;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.io.IOException;
import java.io.Writer;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.TreeSet;
Expand Down Expand Up @@ -103,9 +104,9 @@ private void writeProvides() {
if (aspect != null && !aspect.isEmpty()) {
autoProvidesAspects.add(aspect);
}
final String forExternal = metaData.autoProvides();
final var forExternal = metaData.autoProvides();
if (forExternal != null && !forExternal.isEmpty() && !forExternal.contains("<")) {
autoProvides.add(forExternal);
autoProvides.addAll(forExternal);
}
}
if (!autoProvides.isEmpty()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,17 @@ String providesAspect() {
return providesAspect;
}

UType autoProvides() {
List<UType> autoProvides() {
if (!autoProvide || !providesAspect.isEmpty()) {
return null;
return List.of();
}
if (baseTypeIsInterface || interfaceTypes.isEmpty()) {
return Util.unwrapProvider(baseType.asType());
if (baseTypeIsInterface) {
return List.of(Util.unwrapProvider(baseType.asType()));
}
return interfaceTypes.get(0);
var autoProvides = new ArrayList<>(interfaceTypes);
autoProvides.addAll(extendsTypes);
autoProvides.add(Util.unwrapProvider(baseType.asType()));
return autoProvides;
}

List<UType> provides() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package io.avaje.inject.generator;


import javax.lang.model.element.Element;
import javax.lang.model.element.TypeElement;
import java.util.List;
import java.util.Optional;
import java.util.Set;

import static java.util.stream.Collectors.toList;
Expand Down Expand Up @@ -44,8 +42,10 @@ List<String> provides() {
return extendsReader.provides().stream().map(UType::full).collect(toList());
}

String autoProvides() {
return Optional.ofNullable(extendsReader.autoProvides()).map(UType::full).orElse(null);
List<String> autoProvides() {
return extendsReader.autoProvides().stream()
.map(UType::full)
.collect(toList());
}

String providesAspect() {
Expand Down
4 changes: 2 additions & 2 deletions inject/src/main/java/io/avaje/inject/spi/DependencyMeta.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
String[] dependsOn() default {};

/**
* Type deemed to be reasonable to provide to external module.
* Types deemed to be reasonable to provide to external module.
* <p>
* Used to support multiple module wiring automatically (as alternative to using explicit InjectModule annotation).
*/
String autoProvides() default "";
String[] autoProvides() default {};

}