Skip to content

Add io.avaje.inject @PostConstruct/@PreDestroy annotations #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

rbygrave
Copy link
Contributor

@rbygrave rbygrave commented Nov 2, 2020

We can use any @PostConstruct or @PreDestory annotation. Adding these as avaje inject annotations means that people don't need to depend on the JEE javax.annotation or jakarta.annotation for these annotations.

That is, we consider them important enough to have our own (and dependency on jakarta.annotation for these is not ideal).

@norrisjeremy
Copy link
Contributor

What do you think about adding an @Priority as well?

@rbygrave
Copy link
Contributor Author

rbygrave commented Nov 2, 2020

What do you think about adding an @priority as well?

I think it's a good idea. I almost have a PR that take any Priority annotation.

@rbygrave rbygrave self-assigned this Nov 2, 2020
@rbygrave rbygrave added the enhancement New feature or request label Nov 2, 2020
@rbygrave rbygrave added this to the 2.1 milestone Nov 2, 2020
@rbygrave rbygrave merged commit 2c1ddb6 into master Nov 2, 2020
@rbygrave rbygrave deleted the feature/PostConstruct branch November 16, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants