Add @Priority and make it the default #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this, as it allows using Priority based injection without having to pull in potentially problematic javax.annotation-api dependency. |
norrisjeremy
reviewed
Nov 2, 2020
| @@ -16,28 +17,30 @@ | |||
| @Test | |||
| public void getBeansByPriority() { | |||
|
|
|||
| final List<Somei> beans = SystemContext.getBeansByPriority(Somei.class); | |||
| assertThat(beans).hasSize(2); | |||
| final List<Somei> beans = SystemContext.context().getBeansByPriority(Somei.class, Priority.class); | |||
There was a problem hiding this comment.
This test looks identical to getBeansByPriority_withAnnotation: should one of them be removed or tweaked?
There was a problem hiding this comment.
Yes, I'll merge and sort that out - thanks.
norrisjeremy
reviewed
Nov 2, 2020
|
|
||
| @Override | ||
| public String other() { | ||
| return "a"; |
There was a problem hiding this comment.
Minor nit, but should this be return "c";?
There was a problem hiding this comment.
Yes it should, it will be nice to fix it - thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.