Tweaks for PostConstruct/PreDestory changes #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
norrisjeremy
commented
Nov 2, 2020
norrisjeremy
commented
- Allow PostConstruct/PreDestory annotations from other packages.
- Remove javax.annotation-api dependency since it is no longer strictly required.
|
Excellent, thanks for that. |
rbygrave
approved these changes
Nov 2, 2020
| @@ -264,14 +264,12 @@ private void readMethod(Element element, boolean factory) { | |||
| } | |||
| } | |||
|
|
|||
| if (context.isPostConstructAvailable()) { | |||
There was a problem hiding this comment.
Thanks for spotting that ... ah, tests passed because it was still in the classpath - nice !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.