Add javadoc comments into generated code #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback to using to using io.avaje.inject.spi.Generated when javax.annotation.processing.Generated is not available (Java8 & JPMS)
norrisjeremy
reviewed
Nov 3, 2020
| @@ -53,7 +53,7 @@ | |||
| } | |||
|
|
|||
| private String generatedAnnotation(boolean jdk8) { | |||
| return jdk8 ? null : isTypeAvailable(Constants.GENERATED_9) ? Constants.GENERATED_9 : null; | |||
| return jdk8 ? Constants.GENERATED_LOCAL : isTypeAvailable(Constants.GENERATED_9) ? Constants.GENERATED_9 : Constants.GENERATED_LOCAL; | |||
There was a problem hiding this comment.
What about just switching to always using a local @Generated annotation regardless of the JDK version or if JPMS is in use?
I think that's what Lombok finally decided to do.
There was a problem hiding this comment.
Yes, that is pretty tempting. I've had a little discussion on the jigsaw mailing list about this and at this stage I'm pretty confident that we ultimately can't use javax.annotation.processing.Generated with JPMS so just using the local one makes more and more sense to me now.
|
I like this too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.