Skip to content

[test] remove hard dependency on events #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

SentryMan
Copy link
Collaborator

Saw strange behavior when I tried excluding the events dependency and running tests.

@SentryMan SentryMan added the bug Something isn't working label Apr 2, 2025
@SentryMan SentryMan added this to the 11.5 milestone Apr 2, 2025
@SentryMan SentryMan requested a review from rbygrave April 2, 2025 04:44
@SentryMan SentryMan self-assigned this Apr 2, 2025
@SentryMan SentryMan enabled auto-merge April 2, 2025 04:44
Saw strange behavior when I tried excluding the events dependency and running tests
@SentryMan SentryMan force-pushed the test-merge-services branch from 0967668 to 6195d2b Compare April 2, 2025 04:55
@SentryMan SentryMan changed the title Disable merge services for test compilation [test] remove hard dependency on events Apr 2, 2025
@SentryMan
Copy link
Collaborator Author

SentryMan commented Apr 2, 2025

hmm.
EDIT: nvm it works

@SentryMan SentryMan removed the request for review from rbygrave April 2, 2025 04:59
@SentryMan SentryMan marked this pull request as draft April 2, 2025 04:59
auto-merge was automatically disabled April 2, 2025 04:59

Pull request was converted to draft

@SentryMan SentryMan marked this pull request as ready for review April 2, 2025 05:57
@SentryMan SentryMan requested a review from rbygrave April 2, 2025 05:57
@SentryMan SentryMan enabled auto-merge April 2, 2025 05:57
@SentryMan SentryMan merged commit fbefe26 into avaje:master Apr 2, 2025
5 checks passed
@SentryMan SentryMan deleted the test-merge-services branch April 10, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants