Skip to content

Add test module blackbox-multi-scope #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

rbygrave
Copy link
Contributor

@rbygrave rbygrave commented Apr 7, 2025

This is for testing out the multi-scope cases in a separate test module.

The guts is that to build the scope we currently need to order the modules:

  public static BeanScope buildScope() {
    return BeanScope.builder()
      .modules(new ModAModule(), new ModCModule(), new ModBModule(),  new CrossCutModule())
      .build();
  }
  • CrossCut requires ModA and ModB
  • ModB requires ModC

The ordering of the modules should work off the requires.

This is for testing out the multi-scope cases in a separate test module.
@rbygrave rbygrave requested review from SentryMan and Copilot April 7, 2025 08:45
@rbygrave rbygrave self-assigned this Apr 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • blackbox-multi-scope/pom.xml: Language not supported
  • pom.xml: Language not supported
Comments suppressed due to low confidence (2)

blackbox-multi-scope/src/test/java/org/multi/crosscut/BeanCrossTest.java:16

  • The configuration for the CrossCutModule is commented out, which may lead to incomplete testing of the intended scope behavior. Consider uncommenting it to ensure that the test accurately verifies module wiring.
//      .modules(new CrossCutModule())

blackbox-multi-scope/src/test/java/org/multi/crosscut/BeanCrossTest.java:19

  • The assertions for verifying bean retrieval are commented out, resulting in a test that doesn't validate any functionality. Please uncomment or update the assertions to provide actual test coverage.
//      var beanInModB = beanScope.get(BeanInModB.class);

@rbygrave rbygrave merged commit 5751e36 into master Apr 7, 2025
9 checks passed
@SentryMan SentryMan deleted the feature/multi-scope branch June 24, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants