Skip to content

initial commit #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged

initial commit #1

merged 1 commit into from
Apr 20, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Apr 20, 2023

This is what I got so far, I mainly based this off of Jsonb. Generator isn't there yet, but wanted to get feedback on the interfaces.

@rob-bygrave
Copy link
Contributor

Yeah cool. I'll merge it in and then do some PR's.

Generator isn't there yet, but wanted to get feedback on the interfaces.

Agreed. We can completely forget about the generation for a while and mock/prototype the API.

Thoughts:

  • There are 2 APIs, the public one and the spi one that the [generated] component will use
  • The public one might throw an exception (with a structure that contains the set of constraint violations)
  • I think ConstraintViolation is in the public API so lets move that up from the stream package
  • I think next'ish step might be to add fields to example Pojo ... String, LocalDate ... and mock up something that validates those types (required, min length, max length etc) ...

@rob-bygrave rob-bygrave merged commit e7bb544 into avaje:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants