Skip to content

Add tests for nested validation with nullable #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package example.avaje.nested;

import io.avaje.lang.Nullable;
import io.avaje.validation.ValidPojo;
import io.avaje.validation.constraints.NotNull;
import jakarta.validation.constraints.NotBlank;
import jakarta.validation.constraints.Size;

@ValidPojo
public class AContactWithNullable {

@NotBlank
public String firstName;
@Size(max = 5)
public String lastName;

@Nullable
public AAddress address;

public AContactWithNullable(String firstName, String lastName) {
this.firstName = firstName;
this.lastName = lastName;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class ANestedTest {
final Validator validator = Validator.builder().build();

@Test
void valid() {
void validateNested() {
var contact = new AContact("Rob", "TooLargeForHere");
contact.address = new AAddress("", "TooBigHere", -1);

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
package example.avaje.nested;

import io.avaje.validation.ConstraintViolationException;
import io.avaje.validation.Validator;
import org.junit.jupiter.api.Test;

import java.util.ArrayList;

import static org.assertj.core.api.Assertions.assertThat;

class ANestedWithNullableTest {

final Validator validator = Validator.builder().build();

@Test
void validateNestedSkipNullAddress() {
var contact = new AContactWithNullable("Rob", "TooLargeForHere");
contact.address = null;

try {
validator.validate(contact);
} catch (ConstraintViolationException e) {
var violations = new ArrayList<>(e.violations());
assertThat(violations).hasSize(1);

var v0 = violations.get(0);
assertThat(v0.path()).isEqualTo("");
assertThat(v0.propertyName()).isEqualTo("lastName");
assertThat(v0.message()).isEqualTo("size must be between 0 and 5");
}
}

@Test
void validateNestedAddress() {
var contact = new AContactWithNullable("Rob", "TooLargeForHere");
contact.address = new AAddress("line1", "ok", 12);

try {
validator.validate(contact);
} catch (ConstraintViolationException e) {
var violations = new ArrayList<>(e.violations());
assertThat(violations).hasSize(1);

var v0 = violations.get(0);
assertThat(v0.path()).isEqualTo("");
assertThat(v0.propertyName()).isEqualTo("lastName");
assertThat(v0.message()).isEqualTo("size must be between 0 and 5");
}
}

@Test
void validateNested() {
var contact = new AContactWithNullable("Rob", "TooLargeForHere");
contact.address = new AAddress("", "TooBigHere", -1);

try {
validator.validate(contact);
} catch (ConstraintViolationException e) {
var violations = new ArrayList<>(e.violations());
assertThat(violations).hasSize(4);

var v0 = violations.get(0);
assertThat(v0.path()).isEqualTo("");
assertThat(v0.propertyName()).isEqualTo("lastName");
assertThat(v0.message()).isEqualTo("size must be between 0 and 5");

var v1 = violations.get(1);
assertThat(v1.path()).isEqualTo("address");
assertThat(v1.propertyName()).isEqualTo("line1");
assertThat(v1.message()).isEqualTo("must not be blank");

var v2 = violations.get(2);
assertThat(v2.path()).isEqualTo("address");
assertThat(v2.propertyName()).isEqualTo("line2");
assertThat(v2.message()).isEqualTo("size must be between 0 and 4");

var v3 = violations.get(3);
assertThat(v3.path()).isEqualTo("address");
assertThat(v3.propertyName()).isEqualTo("longValue");
assertThat(v3.message()).isEqualTo("must be greater than 0");
}
}
}