Skip to content

refactor init and use size adapter #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 1, 2023
Merged

refactor init and use size adapter #8

merged 10 commits into from
May 1, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Apr 21, 2023 •
edited
Loading

  • remove the core validation collection method (using the size adapter is preferable)
  • move validation initialization outside of generated adapter
  • annotation attribute map is now string object (for array values and other stuff)

@SentryMan
Copy link
Collaborator Author

@rbygrave Yeah, I'm good with this

@rbygrave
Copy link
Contributor

rbygrave commented May 1, 2023

I'll merge it in. Definitely a few thoughts to discuss.

@rbygrave rbygrave merged commit 0d4211b into avaje:main May 1, 2023
@SentryMan SentryMan deleted the hmm branch May 1, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave