Skip to content

Update BeanValidator for ValidationException.Violation with cause #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 27, 2023
Merged

Update BeanValidator for ValidationException.Violation with cause #87

merged 6 commits into from
Jul 27, 2023

Conversation

rbygrave
Copy link
Contributor

@rbygrave rbygrave commented Jul 27, 2023 •
edited
Loading

Also:

  • module-info, make io.avaje.validation.plugin static (optional)
  • Change ConstraintViolation into a record type
  • Using avaje-http-api 2.0-RC2
  • Hibernate test showing path in the form contacts[0].name for nested collections
  • Rename ConstraintViolation propertyName -> field + fix path to be consistent with hibernate validator

@rbygrave rbygrave self-assigned this Jul 27, 2023
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 27, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

rbygrave added 5 commits July 27, 2023 12:40
@rbygrave
Modify module-info, make io.avaje.validation.plugin static (optional)
cc54292
@rbygrave
Change ConstraintViolation into a record type
8db1ef9
@rbygrave
Using avaje-http-api 2.0-RC2
a2c9f3b
@rbygrave
Hibernate test showing path in the form contacts[0].name for nested c…
d9869b4 
…ollections

Currently for path we have:
contacts.0.name

But need to change to:
contacts[0].name

Also the path should be the "full path" including the field/property (and not just the prefix to the property as it is currently)
@rbygrave
Rename ConstraintViolation propertyName -> field + fix path to be con…
e7e0d73 
…sistent with hibernate validator

In terms of path it should be
- the full path including the field
- collections indexed like contacts[0].name rather than contacts.0.name
@rbygrave rbygrave merged commit e4e7a24 into main Jul 27, 2023
@rbygrave rbygrave deleted the feature/module-info-2 branch July 27, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SentryMan SentryMan SentryMan approved these changes

Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbygrave @SentryMan