Skip to content

Add a AdapterCreateRequest type to combine the parameters passed when… #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

rbygrave
Copy link
Contributor

… creating a ValidationAdapter

Combines the attributes of:

ValidationAdapter<?> create(
    Class<? extends Annotation> annotationType,
    ValidationContext ctx,
    Set<Class<?>> groups,
    Map<String, Object> attributes);
}

… creating a ValidationAdapter

Combines the attributes of:

    ValidationAdapter<?> create(
        Class<? extends Annotation> annotationType,
        ValidationContext ctx,
        Set<Class<?>> groups,
        Map<String, Object> attributes);
    }
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 28, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the tests and you're golden

@rbygrave
Copy link
Contributor Author

fix the tests and you're golden

It was the ValidationProcessorTest.testGeneration(). Not sure why it's failing, disabled for now and will get back to looking at it.

@rbygrave rbygrave merged commit 61f30ab into main Jul 30, 2023
@rbygrave rbygrave deleted the feature/Length branch July 30, 2023 20:24
@SentryMan
Copy link
Collaborator

looks like that test was important, custom adapters are busted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants