Skip to content

fix: PureConfig ProductHint were not picked up correctly #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2019
Merged

fix: PureConfig ProductHint were not picked up correctly #108

merged 1 commit into from
Dec 18, 2019

Conversation

jakubjanecek
Copy link
Collaborator

No description provided.

@jakubjanecek jakubjanecek requested a review from hanny24 December 18, 2019 15:08
@jakubjanecek jakubjanecek self-assigned this Dec 18, 2019
hanny24
hanny24 reviewed Dec 18, 2019
View reviewed changes
Copy link
Contributor

@hanny24 hanny24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually implemented it by taking implicit hint for each ConfigReader. This seems quite clumsy to me.

@jakubjanecek
Copy link
Collaborator Author

So making ConfigReaders a class? Is there any real benefit except that you think it's clumsy? For the user the end result is the same.

@jakubjanecek jakubjanecek merged commit a356880 into master Dec 18, 2019
@jakubjanecek jakubjanecek deleted the fix/PureConfigHints branch December 19, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanny24 hanny24 hanny24 left review comments

Assignees

@jakubjanecek jakubjanecek

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubjanecek @hanny24