Skip to content

feat: Add jvm-execution, jvm-ssl and jvm-system modules #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2019

Conversation

jakubjanecek
Copy link
Collaborator

Implementation of JVM-related utilities for std in/out, clock, random
number generation, SSL context initialization and thread pools.

docs: Add section about jvm-* modules

refactor: Add use of jvm-* modules to example

build: Put test dependencies to separate object

@jakubjanecek jakubjanecek added the feature New feature or request label Sep 24, 2019
@jakubjanecek jakubjanecek self-assigned this Sep 24, 2019
Copy link
Contributor

@tomasherman tomasherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't have time to do a proper review right now - for now just couple of points

Implementation of JVM-related utilities for std in/out, clock, random
number generation, SSL context initialization and thread pools.

docs: Add section about jvm-* modules

refactor: Add use of jvm-* modules to example

build: Put test dependencies to separate object
@jakubjanecek
Copy link
Collaborator Author

I've tried to address all of your comments somehow. Please have another look at it. I removed Clock because they can be created easily so no need for a module (I included them in SystemModule just for simplicity). I did not split the RandomModule and ConsoleModule into separate SBT modules because it seems like too much overhead for nothing.

@augi
Copy link
Member

augi commented Sep 24, 2019

Btw. when I wrote about splitting to more modules, I meant *Module class, not sbt module.

augi
augi previously approved these changes Sep 24, 2019
hanny24
hanny24 previously approved these changes Sep 24, 2019
@jakubjanecek jakubjanecek dismissed stale reviews from hanny24 and augi via 7dcb657 September 24, 2019 18:31
@jakubjanecek jakubjanecek merged commit 5b50d3c into master Sep 24, 2019
@jakubjanecek jakubjanecek deleted the feat/jvm branch September 24, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

Successfully merging this pull request may close these issues.

5 participants