-
Notifications
You must be signed in to change notification settings - Fork 21
feat: Add jvm-execution, jvm-ssl and jvm-system modules #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't have time to do a proper review right now - for now just couple of points
jvm-system/src/main/scala/com/avast/server/toolkit/system/SystemModule.scala
Outdated
Show resolved
Hide resolved
jvm-system/src/main/scala/com/avast/server/toolkit/system/SystemModule.scala
Outdated
Show resolved
Hide resolved
b094ed6
to
bb1ff62
Compare
jvm-execution/src/main/scala/com/avast/server/toolkit/execution/ExecutorModule.scala
Outdated
Show resolved
Hide resolved
jvm-execution/src/main/scala/com/avast/server/toolkit/execution/ExecutorModule.scala
Outdated
Show resolved
Hide resolved
jvm-execution/src/test/scala/com/avast/server/toolkit/execution/ExecutorModuleTest.scala
Outdated
Show resolved
Hide resolved
jvm-ssl/src/test/scala/com/avast/server/toolkit/ssl/SslContextModuleTest.scala
Outdated
Show resolved
Hide resolved
jvm-system/src/main/scala/com/avast/server/toolkit/system/SystemModule.scala
Outdated
Show resolved
Hide resolved
...tion/src/main/scala/com/avast/server/toolkit/execution/LoggingUncaughtExceptionHandler.scala
Show resolved
Hide resolved
jvm-execution/src/main/scala/com/avast/server/toolkit/execution/ExecutorModule.scala
Outdated
Show resolved
Hide resolved
jvm-execution/src/main/scala/com/avast/server/toolkit/execution/ExecutorModule.scala
Outdated
Show resolved
Hide resolved
...tion/src/main/scala/com/avast/server/toolkit/execution/LoggingUncaughtExceptionHandler.scala
Show resolved
Hide resolved
jvm-ssl/src/main/scala/com/avast/server/toolkit/ssl/SslContextModule.scala
Outdated
Show resolved
Hide resolved
jvm-system/src/main/scala/com/avast/server/toolkit/system/SystemModule.scala
Outdated
Show resolved
Hide resolved
Implementation of JVM-related utilities for std in/out, clock, random number generation, SSL context initialization and thread pools. docs: Add section about jvm-* modules refactor: Add use of jvm-* modules to example build: Put test dependencies to separate object
bb1ff62
to
8c3afef
Compare
jvm-system/src/main/scala/com/avast/server/toolkit/system/SystemModule.scala
Outdated
Show resolved
Hide resolved
jvm-system/src/main/scala/com/avast/server/toolkit/system/SystemModule.scala
Outdated
Show resolved
Hide resolved
jvm-system/src/main/scala/com/avast/server/toolkit/system/SystemModule.scala
Outdated
Show resolved
Hide resolved
I've tried to address all of your comments somehow. Please have another look at it. I removed |
Btw. when I wrote about splitting to more modules, I meant |
Implementation of JVM-related utilities for std in/out, clock, random
number generation, SSL context initialization and thread pools.
docs: Add section about jvm-* modules
refactor: Add use of jvm-* modules to example
build: Put test dependencies to separate object