fix: Remove WartRemover as it was not working properly on Scala 2.13 #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: Update dependencies refactor: Small improvements
jakubjanecek
added
bug
|
After switching to Scala 2.13 the release failed: https://github.com/avast/scala-server-toolkit/runs/436430636?check_suite_focus=true#step:8:763 I spent a lot of time debugging the problems (trying to tweak different SBT settings), trying to find some existing problem in SBT or Scaladoc or something like that related to Scala 2.13 but I was unsuccessful. Finally I found out that the problem lies in WartRemover which even though supports Scala 2.13 it did not work well together with SemanticDB which is necessary for Scalafix. I consider Scalafix better for the future so I have decided to remove WartRemover altogether. |
jendakol
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: Update dependencies
refactor: Small improvements