feat: Implement Fs2KafkaModule #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanny24
reviewed
May 25, 2020
There was a problem hiding this comment.
What I don't like about it is a fact that it won't allow you configure parts of the kafka client that are not expected by this code. Imagine a new kafka client is released and it adds a new config option. SST needs to be updated before you'll actually be able to configure that. I think there should be some sort of escape hatch ie using Map[String,String]. Or did I miss something?
|
It allows you to "escape" using |
hanny24
approved these changes
May 25, 2020
|
I'm planning to use it ;) Thanks, I will add a link to the docs. |
jsilva
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements subproject for FS2 Kafka.
Closes #67