Skip to content

feat: Add *ResourceApp trait to allow more generic applications #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

feat: Add *ResourceApp trait to allow more generic applications #31

merged 1 commit into from
Oct 10, 2019

Conversation

jakubjanecek
Copy link
Collaborator

I am not sure about the use of this, I think it's quite limited. But it does not hurt to have it so if you think it's good to have it we can merge it.

@jakubjanecek jakubjanecek requested a review from augi October 10, 2019 15:13
@jakubjanecek jakubjanecek self-assigned this Oct 10, 2019
augi
augi approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@augi augi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe log the A (suppose that toString returned something meaningful).

@jakubjanecek
Copy link
Collaborator Author

toString is explicitly banned by Scalazzi which we try to adhere to :) It does not make sense to just think something usable will be returned. What we could do is requires typeclass called Show which is basically toString but explicit so that the use of the trait needs to provide it. Should I?

@augi
Copy link
Member

augi commented Oct 10, 2019

Please no, keep it as is.

@jakubjanecek jakubjanecek merged commit f16f1ea into master Oct 10, 2019
@jakubjanecek jakubjanecek deleted the feat/XxxResourceApp branch October 14, 2019 20:09
@jakubjanecek jakubjanecek added the feature New feature or request label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augi augi augi approved these changes

Assignees

@jakubjanecek jakubjanecek

Labels
feature New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubjanecek @augi