Skip to content

feat: Add ssl-config module #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2019
Merged

feat: Add ssl-config module #44

merged 2 commits into from
Oct 21, 2019

Conversation

jakubjanecek
Copy link
Collaborator

BREAKING CHANGE: SslContextModule from jvm was replaced by the new one

@jakubjanecek
feat: Add ssl-config module
14407fe 
BREAKING CHANGE: SslContextModule from jvm was replaced by the new one
@jakubjanecek jakubjanecek added the feature New feature or request label Oct 18, 2019
@jakubjanecek jakubjanecek requested review from augi and jendakol October 18, 2019 09:56
@jakubjanecek jakubjanecek self-assigned this Oct 18, 2019
@jakubjanecek jakubjanecek requested review from sideeffffect and removed request for augi October 18, 2019 10:20
sideeffffect
sideeffffect suggested changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use Typesafe config as parameter

@jakubjanecek jakubjanecek removed the request for review from jendakol October 21, 2019 08:10
@jakubjanecek jakubjanecek merged commit 4d1bf18 into master Oct 21, 2019
@mergify mergify bot deleted the feat/SslConfig branch October 21, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideeffffect sideeffffect sideeffffect approved these changes

Assignees

@jakubjanecek jakubjanecek

Labels
feature New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubjanecek @sideeffffect