Skip to content

Add ConfigWriter for Flyway and Doobie #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Add ConfigWriter for Flyway and Doobie #502

merged 3 commits into from
Mar 25, 2021

Conversation

nb-ceffa
Copy link
Contributor

No description provided.

@nb-ceffa nb-ceffa requested a review from jakubjanecek March 25, 2021 15:46
@nb-ceffa nb-ceffa self-assigned this Mar 25, 2021
implicit val doobieDoobieHikariConfigReader: ConfigReader[DoobieHikariConfig] = deriveReader
implicit val doobieDoobieHikariConfigWriter: ConfigWriter[DoobieHikariConfig] = deriveWriter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be part of ConfigReaders trait, right? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ of course!

implicit val flywayFlywayConfigReader: ConfigReader[FlywayConfig] = deriveReader
implicit val flywayFlywayConfigWriter: ConfigWriter[FlywayConfig] = deriveWriter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here.

@nb-ceffa nb-ceffa requested a review from jakubjanecek March 25, 2021 16:40
@mergify mergify bot merged commit 300f5e0 into master Mar 25, 2021
@mergify mergify bot deleted the config_writers branch March 25, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants