fix: Set default value for thread keep-alive to 1 minute #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Make blocking thread pool executor configurable Closes #593
| @@ -53,56 +53,71 @@ class ExecutorModule[F[_]: Sync]( | |||
|
|
|||
| object ExecutorModule { | |||
|
|
|||
| private final val DefaultBlockingExecutorConfig = ThreadPoolExecutorConfig(0, Int.MaxValue, allowCoreThreadTimeout = true) | |||
|
|
|||
| /** Makes [[com.avast.sst.jvm.execution.ExecutorModule]] with default callback executor and extra [[cats.effect.Blocker]] executor | |||
| * for blocking operations. | |||
| */ | |||
| def makeDefault[F[_]: Sync]: Resource[F, ExecutorModule[F]] = { | |||
| for { | |||
| numOfCpus <- Resource.eval(Sync[F].delay(Runtime.getRuntime.availableProcessors)) | |||
| coreSize = numOfCpus * 2 | |||
There was a problem hiding this comment.
Btw, I think that this is a bit questionable, but that is for a different debate.
I think you've already seen this before 😸
https://twitter.com/impurepics/status/987758585722621957?lang=en
and
https://github.com/ChristopherDavenport/linebacker
There was a problem hiding this comment.
The theory is that num of CPUs is the right number but in practice (and I've seen this discussed somewhere long in the past) is that a bit higher number might work better. And I think I also got inspired in ZIO runtime. Anyway, I don't think there's much difference so if you show me at least some examples or documents (not just one image ;) ) I think we could change it.
sideeffffect
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Make blocking thread pool executor configurable
Closes #593