Feat/scala3 hermant #872
Feat/scala3 hermant #872
Conversation
…eat/scala3-hermant
|
wohoo finally green |
tomasherman
requested review from
jakubjanecek,
havelkahonza,
sideeffffect and
jsilva
| @@ -25,13 +31,13 @@ object BuildSettings { | |||
| description := "Functional programming toolkit for building server applications in Scala.", | |||
| licenses := Seq("MIT" -> url("https://raw.githubusercontent.com/avast/scala-server-toolkit/master/LICENSE")), | |||
| developers := List(Developer("jakubjanecek", "Jakub Janecek", "[email protected]", url("https://www.avast.com"))), | |||
| scalaVersion := "2.13.8", | |||
| crossScalaVersions := List(scalaVersion.value, "2.12.15"), | |||
| scalaVersion := scala3, | |||
There was a problem hiding this comment.
I'm not sure about having Scala 3 as the default is a good idea.
Wouldn't having 2.13 as the default save us a lot of headache with Scalafix (among other things)?
There was a problem hiding this comment.
idk, in my view scala3 is the future so i would vote for shaping the code towards that ... i would also like to move further towards scala3 code in future PRs using compiler toggles etc
There was a problem hiding this comment.
My first choice would probably also be 2.13 for now but if everything works and we can compile to both versions the default is probably not that important.
There was a problem hiding this comment.
it only makes a big difference for mdoc imho ... if its all the same to you, i would try to coarse the code into scala3 compatible code as much as possible so i think scala3 default is the best way to go
|
(marked as draft so that it's not merged until everything is in place) |
|
ok i think this is ready for review if anyone else is interested |
| @@ -25,13 +31,13 @@ object BuildSettings { | |||
| description := "Functional programming toolkit for building server applications in Scala.", | |||
| licenses := Seq("MIT" -> url("https://raw.githubusercontent.com/avast/scala-server-toolkit/master/LICENSE")), | |||
| developers := List(Developer("jakubjanecek", "Jakub Janecek", "[email protected]", url("https://www.avast.com"))), | |||
| scalaVersion := "2.13.8", | |||
| crossScalaVersions := List(scalaVersion.value, "2.12.15"), | |||
| scalaVersion := scala3, | |||
There was a problem hiding this comment.
My first choice would probably also be 2.13 for now but if everything works and we can compile to both versions the default is probably not that important.
Co-authored-by: Jakub Janeček <[email protected]>
|
Solved all the comments, im going to merge this once all checks pass. Next steps for me is to massage the code into more scala 3 style of code. I will leave it up to @jakubjanecek to release this once he feels like it |
|
thanks for taking the time to review |
attempt at scala3 support based on
feat/scala3.What is it about:
Whats missing:
What had to change:
checktask we now only checkmdoctask for scala3 (we used to do it for all scala versions) - i don't know how to check it for all considering source code is now diverging for scala2 and scala3