Ember support #961
Merged
Ember support #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubjanecek
approved these changes
Aug 20, 2022
There was a problem hiding this comment.
Thank you for your contribution. In general, this is fine, I'd just like to avoid any incompatible changes unless really necessary - so for example the package renames could be avoided. I know it's not perfect but it's better than bugging the users. Could you please update it?
|
Actually I didn't rename anything at first but then I thought - wouldn't there be some collision if both clients end up in one project as dependencies? What do you think? |
|
Sure, so let's put the new implementation into separate package but let's keep everything already existing where it was. OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.