chore: upgrade to graphql 15 #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
force-pushed
the
upgrade-graphql-15
branch
from
c42e643 to
07fc1e2
Compare
dpilch
force-pushed
the
upgrade-graphql-15
branch
from
07fc1e2 to
37460d3
Compare
dpilch
changed the title
6 tasks
dpilch
changed the title
AaronZyLee
approved these changes
Jan 23, 2023
| @@ -40,12 +40,13 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@graphql-codegen/testing": "^1.17.7", | |||
| "graphql": "^14.5.8", | |||
| "@graphql-codegen/typescript": "^2.8.3", | |||
There was a problem hiding this comment.
What is this package used for? Looks like it is newly added.
There was a problem hiding this comment.
Test would fail with the following without including this.
FAIL src/__tests__/visitors/appsync-javascript-visitor.test.ts
● Test suite failed to run
Cannot find module '@graphql-codegen/typescript' from '../../node_modules/@graphql-codegen/testing/cjs/resolvers-common.js'
I think GraphQL 14 may have included this dependency before.
|
Planning for an official release. There is already a tagged release (3.3.5-graphql15.0) used for testing. |
phani-srikar
approved these changes
Jan 24, 2023
phani-srikar
suggested changes
Jan 24, 2023
| @@ -49,7 +49,8 @@ exports[`JSON output should generate JSON output for a mutation with an enum and | |||
| \\"responseName\\": \\"__typename\\", | |||
| \\"fieldName\\": \\"__typename\\", | |||
| \\"type\\": \\"String!\\", | |||
| \\"isConditional\\": false | |||
| \\"isConditional\\": false, | |||
| \\"isDeprecated\\": false | |||
There was a problem hiding this comment.
why is this extra field being added in the tests?
There was a problem hiding this comment.
isDepreacted became required on GraphQLField in version 15. So it now shows up on all fields including __typename. graphql/graphql-js#2469
I don't see this causing any issue though.
phani-srikar
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upgrade
graphqlpackage to be inline withgraphqlversion used in the CLI.https://github.com/aws-amplify/amplify-cli/blob/dev/packages/amplify-cli/package.json#L91
In some rare cases both graphql 14 and 15 were resolved in the package leading to errors.
Issue #, if available
The above error would surface when the CLI was installed via Verdaccio on the macos executor on CircleCI.
#520
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.