Skip to content

Update to ACK runtime v0.26.0, code-generator v0.26.1 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented May 15, 2023

Update to ACK runtime v0.26.0, code-generator v0.26.1



NOTE:
This PR increments the release version of service controller from v0.0.6 to v0.0.7

Once this PR is merged, release v0.0.7 will be automatically created for acm-controller

Please close this PR, if you do not want the new patch release for acm-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building acm-controller ====
Copying common custom resource definitions into acm
Building Kubernetes API objects for acm
Generating deepcopy code for acm
Generating custom resource definitions for acm
Building service controller for acm
Generating RBAC manifests for acm
Running gofmt against generated code for acm
Updating additional GitHub repository maintenance files
==== building acm-controller release artifacts ====
Building release artifacts for acm-v0.0.7
Generating common custom resource definitions
Generating custom resource definitions for acm
Generating RBAC manifests for acm

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly May 15, 2023 23:02
@ack-prow
Copy link

ack-prow bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign redbackthomson for approval by writing /assign @redbackthomson in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from RedbackThomson May 15, 2023 23:02
@ack-prow
Copy link

ack-prow bot commented May 18, 2023

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
acm-codespell 7cb83fd link true /test acm-codespell

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RedbackThomson RedbackThomson merged commit d8ee016 into main Jun 15, 2023
@RedbackThomson RedbackThomson deleted the ack-bot/rt-v0.26.0-codegen-v0.26.1 branch June 15, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants