Skip to content

Set policyName in DescribeScalingPolicies input request #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Jun 26, 2023

When calling ReadOne for ScalingPolicies the controller does not set
policyName into the input causing it to list all the policies related to a
resource and (possibly) pick the wrong one. This PR adds to a controller
the ability to set a policyName to the request, making it easier to read the
latest state.

Description of changes:

  • Set policyName in DescribeScalingPolicies input request

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from akartsky and ryansteakley June 26, 2023 18:55
@ack-prow ack-prow bot added the approved label Jun 26, 2023
@a-hilaly a-hilaly force-pushed the sp-pn branch 2 times, most recently from cb840cd to 08242bc Compare June 26, 2023 19:18
@ack-prow
Copy link

ack-prow bot commented Jun 29, 2023

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
applicationautoscaling-kind-e2e c3e71e9 link true /test applicationautoscaling-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@surajkota
Copy link
Member

Sync offline, Controller errors are gone with the fix in c3e71e9

Next step is to fix/add a test. SageMaker endpoint can scale on 2 different metrics on same dimension, so use that instead of dynamoDB test

@surajkota
Copy link
Member

Closing in favor of #106. There are more issues than what originally planned for.

@surajkota surajkota closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants