Set defaultResyncPeriod helm value to 36000
#450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
jljaco
approved these changes
May 25, 2023
RedbackThomson
suggested changes
May 26, 2023
templates/helm/values.yaml.tpl
Outdated
| @@ -110,7 +110,7 @@ deletionPolicy: delete | |||
| # controller reconciliation configurations | |||
| reconcile: | |||
| # The default duration, in seconds, to wait before resyncing desired state of custom resources. | |||
| defaultResyncPeriod: 0 | |||
| defaultResyncPeriod: 36000 # 10 Hours (https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/reconciler.go#L48-L51) | |||
There was a problem hiding this comment.
I would leave out the link to the code. It's not relevant to most customers who simply consume the default values.
Fixes aws-controllers-k8s/community#1671 The 0 value of `defaultResyncPeriod` causes the controller to use 10 hours as a `resyncPeriod` .. which is a very confusing. This patch sets the default value to 36000 (10 hours in seconds) to match the expected default behaviour. See https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/reconciler.go#L48-L51
a-hilaly
force-pushed
the
helm-resync-period-default
branch
from
a5d6600 to
adb9674
Compare
|
Note that the API Gateway test will continue to fail until aws-controllers-k8s/community#1825 is addressed |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-controllers-k8s/community#1671
The 0 value of
defaultResyncPeriodcauses the controller to use 10hours as a
resyncPeriod.. which is a very confusing.This patch sets the default value to 36000 (10 hours in seconds) to
match the expected default behaviour.
See https://github.com/aws-controllers-k8s/runtime/blob/main/pkg/runtime/reconciler.go#L48-L51
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.