-
Notifications
You must be signed in to change notification settings - Fork 212
fixing boolean flag in deployment args to be on a single line #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing boolean flag in deployment args to be on a single line #457
Conversation
Signed-off-by: Adam D. Cornett <[email protected]>
Hi @acornett21. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging soon as trhis is non blocking...
/retest |
2 similar comments
/retest |
/retest |
/test all |
/test dynamodb-controller-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice catch @acornett21 ! tyty!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, acornett21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ntrollers-k8s#457) Issue #, if available: N/A Description of changes: Fixing deployment `args` to have boolean values on a single line. This is needed since the presence of the flag itself is a `truthy` statement, and the next line for the `env` is ignored. See [this](aws-controllers-k8s#455 (comment)) comment on `leader-elect` PR for more info. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available:
N/A
Description of changes:
Fixing deployment
args
to have boolean values on a single line. This is needed since the presence of the flag itself is atruthy
statement, and the next line for theenv
is ignored. See this comment onleader-elect
PR for more info.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.