Skip to content

feat(crossplane): Add context to isUpToDate and return diff #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

MisterMX
Copy link
Contributor

@MisterMX MisterMX commented Aug 4, 2023

Description of changes:

This adds a context.Context parameter to the isUpToDate function in the Crossplane controller template.

Required for crossplane-contrib/provider-aws#1828.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jaypipes and vijtrip2 August 4, 2023 11:05
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 4, 2023
@ack-prow
Copy link

ack-prow bot commented Aug 4, 2023

Hi @MisterMX. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chlunde
Copy link
Contributor

chlunde commented Aug 9, 2023

@jaypipes as a maintainer of crossplane-community/provider-aws, I approve this PR. It would be nice to have it merged. We could also consider moving the templates into provider-aws if we have/get support for external templates, so we don't have to bother you on changes like this.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MisterMX, apologies for the delayed review!

@jaypipes
Copy link
Collaborator

jaypipes commented Aug 9, 2023

/lgtm

@ack-prow ack-prow bot added approved lgtm Indicates that a PR is ready to be merged. labels Aug 9, 2023
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm
/ok-to-test

@ack-prow ack-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 9, 2023
@ack-prow ack-prow bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2023
@ack-prow
Copy link

ack-prow bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, jaypipes, MisterMX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow
Copy link

ack-prow bot commented Aug 9, 2023

@MisterMX: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ecr-controller-test 4b7c1ed link true /test ecr-controller-test
s3-controller-test 4b7c1ed link true /test s3-controller-test
apigatewayv2-controller-test 4b7c1ed link true /test apigatewayv2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

Manually merging as the errors mentioned in the log are not representative of real errors

@a-hilaly a-hilaly merged commit 5e27da3 into aws-controllers-k8s:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants