add hooks for set identifiers #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
requested review from
RedbackThomson
and removed request for
vijtrip2 and
jljaco
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RedbackThomson, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@surajkota: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ack-prow bot
pushed a commit
to aws-controllers-k8s/applicationautoscaling-controller
that referenced
this pull request
Aug 7, 2023
## Description of changes: Customer facing issue in using multiple scaling policies for a scalable dimension because originally the code assumed it is 1:1 mapping. To uniquely identify a scaling policy resource, we need policy name, resource-id, service namespace and scalable dimension. This PR adds ability to create multiple scaling policies per scalable dimension and also updates the following things: - Pass PolicyName for sdkFind, it is a required field in CRD - Added logic to error on missing required fields per description above for DescribeScalingPolicyInput - Updated tests to cover multiple scaling policies scenario per dimension case - Updated test logic to use correct dependency of fixtures and order of execution - Updates the tests to use object oriented style bootstrapping. Hit aws-controllers-k8s/test-infra#368 issue while trying to fix the issue and cannot use latest ack-test without updating the bootstrap logic - Removed duplicate test with dynamodb. SageMaker and dynamodb tests are testing same thing while SM tests have more coverage. No reason to maintain both set of tests, dynamodb tests add additional bootstrapping as well ~~**:warning: Pending before merge**~~ Hit another issue described in aws-controllers-k8s/community#1871. Fix aws-controllers-k8s/code-generator#459 has been merged By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-controllers-k8s/community#1871
Description of changes:
PolicyName field in Describe and Put APIs for ScalingPolicy has a different name and shape.
Because of difference in names, the code gen skips adding it to additional resource identifier for SetIndentifiers. Hesitant to use rename because the shape type is different in both APIs (string vs list of string). Adding hooks to unblock
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.