Fix ENABLE_LEADER_ELECTION env variable name
#466
Conversation
Without fix leader election is always enabled in controller, while permissions might not be given
ack-prow
bot
added
the
needs-ok-to-test
|
Hi @msvticket. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @a-hilaly |
|
Thank you @msvticket ! |
ack-prow
bot
added
ok-to-test
a-hilaly
changed the title
ENABLE_LEADER_ELECTION env variable name
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, msvticket The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
This fixes that setting and use of env variable had different names.
Without this fix leader election is always enabled in controller, but permissions might not be given.
So if leader election isn't enabled in the values you get constant messages like:
E0911 06:54:26.919325 1 leaderelection.go:330] error retrieving resource lock alb-ingress/ack-acm.services.k8s.aws: leases.coordination.k8s.io "ack-acm.services.k8s.aws" is forbidden: User "system:serviceaccount:alb-ingress:ack-acm-controller" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "alb-ingress"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.