Skip to content

Pin ACK runtime to v0.28.0 #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

Pin ACK runtime to v0.28.0 #478

merged 1 commit into from
Dec 14, 2023

Conversation

a-hilaly
Copy link
Member

  • Pin ACK runtime to v0.28.0
  • go mod tidy

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and jljaco December 13, 2023 17:08
@a-hilaly
Copy link
Member Author

/hold

@ack-prow ack-prow bot added approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 13, 2023
@a-hilaly
Copy link
Member Author

/test all

@a-hilaly
Copy link
Member Author

mornitoring the build using Go 1.21.5 and aws-sdk-go 1.49
/cc @acornett21

@ack-prow ACK Prow
Copy link

ack-prow bot commented Dec 14, 2023

@a-hilaly: GitHub didn't allow me to request PR reviews from the following users: acornett21.

Note that only aws-controllers-k8s members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

mornitoring the build using Go 1.21.5 and aws-sdk-go 1.49
/cc @acornett21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member Author

/retest

@a-hilaly
Copy link
Member Author

/assign @ivelichkovich

@ivelichkovich
Copy link

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@ack-prow ACK Prow
Copy link

ack-prow bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ivelichkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,ivelichkovich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member Author

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@ack-prow ack-prow bot merged commit 1f16813 into aws-controllers-k8s:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivelichkovich ivelichkovich ivelichkovich approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

@jljaco jljaco Awaiting requested review from jljaco

Assignees

@ivelichkovich ivelichkovich

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-hilaly @ivelichkovich